FIX(client): Fix PulseAudio regression by nulling buffer #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b5a67c0 a buffer in the PulseAudio backend was made static, but at the same time the memset(0) was removed. In combination, that lead to a bug where the last few frames of any given audio played back was repeated until something else filled the buffer. This commit adds a simple fill to the buffer where the memset(0) previously was fixing the bug.
Hartmnt
force-pushed
the
fix_pulseaudio
branch
from
9bb4486 to
85f3ef1
Compare
Krzmbrzl
approved these changes
Jan 24, 2024
|
The loop was caused by the same audio samples being reproduced continuously. |
|
Yeah, that much is clear :P |
|
The content of the buffer is unchanged if we don't have any audio samples to reproduce, meaning that the same data is reproduced every time the function is called (i.e. for every period, which depends on the buffer size). |
|
Ah, so the callback is called indefinitely and not only when we actually have audio? Okay that makes sense, thanks! |
|
Yeah, it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b5a67c0 a buffer in the PulseAudio backend was made static, but at the same time the memset(0) was removed.
In combination, that lead to a bug where the last few frames of any given audio played back was repeated until something else filled the buffer.
This commit adds a simple fill to the buffer where the memset(0) previously was fixing the bug.
Exact bug location: b5a67c0#diff-3468a698a1554e9292714294b8c8766bff543c8b4949c3fa02ad833084bf2867L648-R665